fix(material-experimental/mdc-select): float label on focus if there's a placeholder #22187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P2
google-cla
bot
added
the
cla: yes
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Mar 11, 2021
Adds an exception for one missing test until angular#22187 is merged.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Mar 11, 2021
Adds an exception for one missing test until angular#22187 is merged.
crisbeto
force-pushed
the
mdc-select-float-labe
branch
from
d9d5501 to
84250b0
Compare
mmalerba
pushed a commit
that referenced
this pull request
Mar 11, 2021
Adds an exception for one missing test until #22187 is merged.
mmalerba
pushed a commit
that referenced
this pull request
Mar 11, 2021
Adds an exception for one missing test until #22187 is merged.
crisbeto
force-pushed
the
mdc-select-float-labe
branch
from
84250b0 to
0517fd0
Compare
andrewseguin
added
target: minor
|
Need rebase (passes global TAP) |
…s a placeholder This is the equivalent of angular#19517 for the MDC-based select. Historically we've only floated the `mat-select` label if a value is selected or the panel is open, because we wouldn't otherwise have anything to show. These changes make it so that we also float it on focus, if there's `placeholder` text that can be shown. This behavior is consistent with `MatInput`.
|
Rebased. |
crisbeto
force-pushed
the
mdc-select-float-labe
branch
from
0517fd0 to
57025be
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the equivalent of #19517 for the MDC-based select.
Historically we've only floated the
mat-selectlabel if a value is selected or the panel is open, because we wouldn't otherwise have anything to show. These changes make it so that we also float it on focus, if there'splaceholdertext that can be shown. This behavior is consistent withMatInput.